Conversation
Signed-off-by: seeg <dev@charlie.fyi>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| 9. **Name:** Choose a name (For the example I used Discord) | ||
| 10. **Slug:** discord (You can choose a different slug, if you do you will need to update the Discord redirect URLand point it to the correct slug.) | ||
| 9. **Name:** Choose a name (For the example I used `Discord`) |
There was a problem hiding this comment.
| 9. **Name:** Choose a name (For the example I used `Discord`) | |
| 9. **Name:** Choose a name (For the example I used Discord) |
There was a problem hiding this comment.
Whew this is an interesting one... per our Style Guide, yes, we use code font for values (values that you enter into a field, like say a URL). But for a name... even though it is a vlaue per se, we wouldn't use code font. Though now you have me thinking on this... ;-)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13095 +/- ##
==========================================
- Coverage 92.82% 92.80% -0.02%
==========================================
Files 792 792
Lines 40218 40218
==========================================
- Hits 37333 37325 -8
- Misses 2885 2893 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dominic-r
left a comment
There was a problem hiding this comment.
Looks good, thanks for your contribution! I'm surprised we never spotted this before today. ( Oh and I don't agree with what Tana said, but let's keep it for a later date as she suggested 😉)
* main: web/user: fix opening application with Enter not respecting new tab setting (#13115) web: bump API Client version (#13113) providers/rac: move to open source (#13015) website/docs: add 2025.2 release notes (#13002) core: clear expired database sessions (#13105) core: bump sentry-sdk from 2.21.0 to 2.22.0 (#13098) core: bump bandit from 1.8.2 to 1.8.3 (#13097) core: bump aws-cdk-lib from 2.178.2 to 2.179.0 (#13099) core: bump goauthentik.io/api/v3 from 3.2024123.4 to 3.2024123.6 (#13100) lifecycle/aws: bump aws-cdk from 2.178.2 to 2.179.0 in /lifecycle/aws (#13101) website/docs: Add AdventureLog Community Integration Documentation (#12928) website/docs: minor fixes (#13095) website/integrations: Update to Wizard and Styling Guide (#12919) web: bump API Client version (#13093) policies/geoip: distance + impossible travel (#12541) root: fix generated API docs not being excluded from codespell (#13091)
Spotted a minor thing while setting up Discord with authentik
make website)