Skip to content

root: fix health status code#12255

Merged
rissson merged 1 commit intomainfrom
go-proxy-fix-health-status-code
Dec 3, 2024
Merged

root: fix health status code#12255
rissson merged 1 commit intomainfrom
go-proxy-fix-health-status-code

Conversation

@rissson
Copy link
Member

@rissson rissson commented Dec 3, 2024

Details

Introduced in #8675


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Dec 3, 2024
@rissson rissson requested a review from a team as a code owner December 3, 2024 14:38
@rissson rissson requested a review from BeryJu December 3, 2024 14:38
@netlify
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 061e92d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/674f17cb92bd950008bdba90

@netlify
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 061e92d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/674f17cb58098c00086f439c

@rissson
Copy link
Member Author

rissson commented Dec 3, 2024

Why is the frontend group required as review? It should be backend according to codeowners

@rissson rissson enabled auto-merge (squash) December 3, 2024 14:39
@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (0670bc8) to head (061e92d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12255      +/-   ##
==========================================
- Coverage   92.69%   92.62%   -0.07%     
==========================================
  Files         762      762              
  Lines       38151    38151              
==========================================
- Hits        35363    35337      -26     
- Misses       2788     2814      +26     
Flag Coverage Δ
e2e 48.99% <ø> (-0.11%) ⬇️
integration 24.76% <ø> (ø)
unit 90.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-061e92dbd01c60c95e6b5ef2ec966ac178ac6298
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-061e92dbd01c60c95e6b5ef2ec966ac178ac6298-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-061e92dbd01c60c95e6b5ef2ec966ac178ac6298

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-061e92dbd01c60c95e6b5ef2ec966ac178ac6298-arm64

Afterwards, run the upgrade commands from the latest release notes.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah didnt we purposefully change that from 204 to 200 a couple versions back?

@rissson rissson merged commit 1623885 into main Dec 3, 2024
@rissson rissson deleted the go-proxy-fix-health-status-code branch December 3, 2024 15:59
@rissson
Copy link
Member Author

rissson commented Dec 3, 2024

We did indeed

kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
* main:
  web: simplify `?inline` handler for Storybook (#12246)
  website/docs: Update Traefik middleware example to reflect latest version of Traefik (#12267)
  website/docs: add . in https://netbird.company* (#12166)
  core: bump goauthentik.io/api/v3 from 3.2024104.1 to 3.2024104.2 (#12263)
  core: bump pydantic from 2.10.2 to 2.10.3 (#12262)
  core: bump github.com/getsentry/sentry-go from 0.29.1 to 0.30.0 (#12264)
  core, web: update translations (#12268)
  website: bump @types/react from 18.3.12 to 18.3.13 in /website (#12269)
  website: bump prettier from 3.4.1 to 3.4.2 in /website (#12270)
  ci: bump actions/attest-build-provenance from 1 to 2 (#12271)
  core: bump golang.org/x/sync from 0.9.0 to 0.10.0 (#12272)
  core: bump django from 5.0.9 to 5.0.10 (#12273)
  core: bump webauthn from 2.3.0 to 2.4.0 (#12274)
  website/integrations: add The Lounge (#11971)
  core: bump python-kadmin-rs from 0.3.0 to 0.4.0 (#12257)
  root: fix health status code (#12255)
  ci: fix should_push always being false (#12252)
  web: bump API Client version (#12251)
  providers/oauth2: Add provider federation between OAuth2 Providers (#12083)
  website/integrations: mastodon: set correct uid field (#11945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants