Skip to content

website/integrations: mastodon: set correct uid field#11945

Merged
tanberry merged 5 commits intogoauthentik:mainfrom
dominic-r:patch-2
Dec 3, 2024
Merged

website/integrations: mastodon: set correct uid field#11945
tanberry merged 5 commits intogoauthentik:mainfrom
dominic-r:patch-2

Conversation

@dominic-r
Copy link
Member

Setting the OIDC_UID_FIELD as sub created users on Mastodon with random usernames. Once this was changed to preferred_username, new users were created with their usernames set in authentik. My assumption is that users would wish to have the same username rather than have a random one generated.

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Setting the `OIDC_UID_FIELD` as `sub` created users on Mastodon with random usernames. Once this was changed to `preferred_username`, new users were created with their usernames set in authentik. My assumption is that users would wish to have the same username rather than have a random one generated.

Signed-off-by: 4d62 <github-user@sdko.org>
@dominic-r dominic-r requested a review from a team as a code owner November 7, 2024 01:45
@netlify
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 54043b4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/673e448b5dcffd00085ac696
😎 Deploy Preview https://deploy-preview-11945--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 54043b4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/673e448bb4670c000867886f
😎 Deploy Preview https://deploy-preview-11945--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (b2c9dff) to head (f641110).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11945      +/-   ##
==========================================
+ Coverage   92.58%   92.63%   +0.05%     
==========================================
  Files         761      761              
  Lines       37822    37822              
==========================================
+ Hits        35016    35038      +22     
+ Misses       2806     2784      -22     
Flag Coverage Δ
e2e 49.30% <ø> (+0.09%) ⬆️
integration 24.91% <ø> (ø)
unit 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but there should be a warning that https://docs.goauthentik.io/docs/sys-mgmt/settings#allow-users-to-change-username should be set to false (which is the default but still) when using preferred_username as the primary identifier

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a suggestion... instead of removing info, we can add info (by showing both).

@dominic-r dominic-r requested review from BeryJu and tanberry November 12, 2024 01:56
@dominic-r
Copy link
Member Author

Not sure if I put that at the right place

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry it took me so long to get to this!

@tanberry tanberry merged commit 4aeb7c8 into goauthentik:main Dec 3, 2024
@dominic-r dominic-r deleted the patch-2 branch December 3, 2024 03:50
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
* main:
  web: simplify `?inline` handler for Storybook (#12246)
  website/docs: Update Traefik middleware example to reflect latest version of Traefik (#12267)
  website/docs: add . in https://netbird.company* (#12166)
  core: bump goauthentik.io/api/v3 from 3.2024104.1 to 3.2024104.2 (#12263)
  core: bump pydantic from 2.10.2 to 2.10.3 (#12262)
  core: bump github.com/getsentry/sentry-go from 0.29.1 to 0.30.0 (#12264)
  core, web: update translations (#12268)
  website: bump @types/react from 18.3.12 to 18.3.13 in /website (#12269)
  website: bump prettier from 3.4.1 to 3.4.2 in /website (#12270)
  ci: bump actions/attest-build-provenance from 1 to 2 (#12271)
  core: bump golang.org/x/sync from 0.9.0 to 0.10.0 (#12272)
  core: bump django from 5.0.9 to 5.0.10 (#12273)
  core: bump webauthn from 2.3.0 to 2.4.0 (#12274)
  website/integrations: add The Lounge (#11971)
  core: bump python-kadmin-rs from 0.3.0 to 0.4.0 (#12257)
  root: fix health status code (#12255)
  ci: fix should_push always being false (#12252)
  web: bump API Client version (#12251)
  providers/oauth2: Add provider federation between OAuth2 Providers (#12083)
  website/integrations: mastodon: set correct uid field (#11945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants