Skip to content

crypto: validate that generated certificate's name is unique#12015

Merged
BeryJu merged 1 commit intomainfrom
crypto/handle-duplicate-cert-name
Nov 13, 2024
Merged

crypto: validate that generated certificate's name is unique#12015
BeryJu merged 1 commit intomainfrom
crypto/handle-duplicate-cert-name

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 13, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 13, 2024 15:07
@netlify
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d38ba18
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6734c0b16d93be0008e5ee6d

@netlify
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d38ba18
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6734c0b1c55fb10008415885

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (a892d4a) to head (d38ba18).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12015      +/-   ##
==========================================
- Coverage   92.57%   92.26%   -0.31%     
==========================================
  Files         761      761              
  Lines       37841    37847       +6     
==========================================
- Hits        35031    34920     -111     
- Misses       2810     2927     +117     
Flag Coverage Δ
e2e 47.92% <20.00%> (-1.27%) ⬇️
integration 24.91% <0.00%> (-0.01%) ⬇️
unit 90.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu
Copy link
Member Author

BeryJu commented Nov 13, 2024

/cherry-pick version-2024.10

@BeryJu BeryJu merged commit 74171e0 into main Nov 13, 2024
@BeryJu BeryJu deleted the crypto/handle-duplicate-cert-name branch November 13, 2024 15:31
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 13, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 13, 2024
…pick #12015) (#12016)

crypto: validate that generated certificate's name is unique (#12015)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant