Skip to content

core: use versioned_script for path only#12003

Merged
BeryJu merged 1 commit intomainfrom
core/use-versioned_script-for-path
Nov 14, 2024
Merged

core: use versioned_script for path only#12003
BeryJu merged 1 commit intomainfrom
core/use-versioned_script-for-path

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 12, 2024

Details

versioned_script used to return a list of HTML strings when we were migrating to versioned scripts (to fallback to loading un-versioned scripts). The fallback has since been removed in a release after the migration. This PR changes the template tag to only format the path


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 12, 2024 21:49
@netlify
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4570606
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6733cd74cebde80008d97412

@netlify
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 4570606
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6733cd7486a5490008f53999

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (1f6ae73) to head (4570606).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12003      +/-   ##
==========================================
- Coverage   92.57%   92.56%   -0.01%     
==========================================
  Files         761      761              
  Lines       37841    37839       -2     
==========================================
- Hits        35030    35027       -3     
- Misses       2811     2812       +1     
Flag Coverage Δ
e2e 49.18% <100.00%> (-0.01%) ⬇️
integration 24.91% <0.00%> (+<0.01%) ⬆️
unit 90.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-45706063143887218e2893138445be8d15cfb738
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-45706063143887218e2893138445be8d15cfb738-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-45706063143887218e2893138445be8d15cfb738

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-45706063143887218e2893138445be8d15cfb738-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 14d0136 into main Nov 14, 2024
@BeryJu BeryJu deleted the core/use-versioned_script-for-path branch November 14, 2024 13:02
@BeryJu
Copy link
Member Author

BeryJu commented Nov 14, 2024

/cherry-pick version-2024.10

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 14, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 14, 2024
core: use versioned_script for path only (#12003)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
kensternberg-authentik added a commit that referenced this pull request Nov 14, 2024
* main:
  providers/ldap: fix global search_full_directory permission not being sufficient (#12028)
  website/docs: 2024.10.2 release notes (#12025)
  lifecycle: fix ak exit status not being passed (#12024)
  core: use versioned_script for path only (#12003)
  core, web: update translations (#12020)
  core: bump google-api-python-client from 2.152.0 to 2.153.0 (#12021)
  providers/oauth2: fix manual device code entry (#12017)
  crypto: validate that generated certificate's name is unique (#12015)
  core, web: update translations (#12006)
  core: bump google-api-python-client from 2.151.0 to 2.152.0 (#12007)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#12011)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#12010)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#12012)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#12013)
  providers/proxy: fix Issuer when AUTHENTIK_HOST_BROWSER is set (#11968)
  website/docs: move S3 ad GeoIP to System Management/Operations (#11998)
  website/integrations: nextcloud: add SSE warning (#11976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant