Skip to content

web/admin: fix duplicate flow labels#11689

Merged
BeryJu merged 2 commits intomainfrom
web/admin/fix-duplicate-flow-labels
Oct 16, 2024
Merged

web/admin: fix duplicate flow labels#11689
BeryJu merged 2 commits intomainfrom
web/admin/fix-duplicate-flow-labels

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 15, 2024

Details

  • Fix duplicate flow input labels in app wizard
  • Remove authentication flow input
  • fix missing reflect on ak-app-icon causing images to be too big

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 15, 2024 16:18
@netlify
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit e34daa5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/670fc86bf066670008b235a1
😎 Deploy Preview https://deploy-preview-11689--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit e34daa5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/670fc86ba681e90008dd7bd1

@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (4a76bb5) to head (e34daa5).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11689      +/-   ##
==========================================
- Coverage   92.77%   92.74%   -0.03%     
==========================================
  Files         736      736              
  Lines       36609    36609              
==========================================
- Hits        33964    33954      -10     
- Misses       2645     2655      +10     
Flag Coverage Δ
e2e 49.37% <ø> (-0.03%) ⬇️
integration 24.96% <ø> (ø)
unit 90.19% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e34daa57e5cf1d189cded1fa0f43af06f1ee7245
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e34daa57e5cf1d189cded1fa0f43af06f1ee7245-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-e34daa57e5cf1d189cded1fa0f43af06f1ee7245

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-e34daa57e5cf1d189cded1fa0f43af06f1ee7245-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the web/admin/fix-duplicate-flow-labels branch from f3abdb2 to e34daa5 Compare October 16, 2024 14:06
@BeryJu BeryJu merged commit c4caef4 into main Oct 16, 2024
@BeryJu BeryJu deleted the web/admin/fix-duplicate-flow-labels branch October 16, 2024 15:19
kensternberg-authentik added a commit that referenced this pull request Oct 18, 2024
* main: (68 commits)
  core: extract object matching from flow manager (#11458)
  admin: store version history (#11520)
  web: bump API Client version (#11706)
  providers/oauth2: add initial JWE support (#11344)
  core, web: update translations (#11703)
  tests/e2e: add forward auth e2e test (#11374)
  web/admin: fix duplicate flow labels (#11689)
  providers/saml: fix incorrect ds:Reference URI (#11699)
  website/docs: Fix websocket default config for nginx proxy manager (#11621)
  core, web: update translations (#11692)
  core: bump uvicorn from 0.31.1 to 0.32.0 (#11693)
  core: bump github.com/prometheus/client_golang from 1.20.4 to 1.20.5 (#11694)
  website/docs: add missing file to sidebar (#11695)
  website/docs: rewrote too long sentence (#11696)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#11697)
  translate: Updates for file web/xliff/en.xlf in fr (#11698)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11683)
  core, web: update translations (#11682)
  core: bump github.com/getsentry/sentry-go from 0.29.0 to 0.29.1 (#11684)
  core: bump github.com/redis/go-redis/v9 from 9.6.1 to 9.6.2 (#11685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants