website/docs: Fix websocket default config for nginx proxy manager#11621
Merged
BeryJu merged 4 commits intogoauthentik:mainfrom Oct 16, 2024
MahmoudAlyuDeen:patch-1
Merged
website/docs: Fix websocket default config for nginx proxy manager#11621BeryJu merged 4 commits intogoauthentik:mainfrom MahmoudAlyuDeen:patch-1
BeryJu merged 4 commits intogoauthentik:mainfrom
MahmoudAlyuDeen:patch-1
Conversation
Resolves: - #10010 - #7323 - #11453 - https://www.reddit.com/r/Authentik/comments/1c5sf6l/authentik_with_nginx_proxy_manager_not_possible/ Signed-off-by: Mahmoud AlyuDeen <mahmoudalyudeen@gmail.com>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BeryJu
reviewed
Oct 10, 2024
Member
BeryJu
left a comment
There was a problem hiding this comment.
Aside from being baffled how this standard nginx configuration breaking NPM, if anything I dont think it should be commented out but rather removed, as it being commented out without a reason makes it even more confusing
Signed-off-by: Mahmoud AlyuDeen <mahmoudalyudeen@gmail.com>
Contributor
Author
Makes sense. I've replaced the current setup with a working and tested I updated the PR title and description accordingly. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11621 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 736 736
Lines 36609 36609
=======================================
+ Hits 33956 33957 +1
+ Misses 2653 2652 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
added a commit
that referenced
this pull request
Oct 18, 2024
* main: (68 commits) core: extract object matching from flow manager (#11458) admin: store version history (#11520) web: bump API Client version (#11706) providers/oauth2: add initial JWE support (#11344) core, web: update translations (#11703) tests/e2e: add forward auth e2e test (#11374) web/admin: fix duplicate flow labels (#11689) providers/saml: fix incorrect ds:Reference URI (#11699) website/docs: Fix websocket default config for nginx proxy manager (#11621) core, web: update translations (#11692) core: bump uvicorn from 0.31.1 to 0.32.0 (#11693) core: bump github.com/prometheus/client_golang from 1.20.4 to 1.20.5 (#11694) website/docs: add missing file to sidebar (#11695) website/docs: rewrote too long sentence (#11696) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#11697) translate: Updates for file web/xliff/en.xlf in fr (#11698) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11683) core, web: update translations (#11682) core: bump github.com/getsentry/sentry-go from 0.29.0 to 0.29.1 (#11684) core: bump github.com/redis/go-redis/v9 from 9.6.1 to 9.6.2 (#11685) ...
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Update suggested configuration replacing
commenting outlines that cause Nginx Proxy Manager host to go offline.Resolves:
Checklist
ak test authentik/)make lint-fix)