sources/oauth: fix link not being saved by BeryJu · Pull Request #10374 · goauthentik/authentik

BeryJu · 2024-07-04T13:52:28Z

Details

closes #10209
closes #10275

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

netlify · 2024-07-04T13:52:43Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`05c6718`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6686a91fcff8af0008298889

netlify · 2024-07-04T13:52:44Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`05c6718`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/6686a91f039d2000084d5380
😎 Deploy Preview	https://deploy-preview-10374--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-07-04T13:58:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (fbad6fb) to head (05c6718).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10374      +/-   ##
==========================================
- Coverage   92.63%   92.62%   -0.01%     
==========================================
  Files         713      713              
  Lines       34988    34989       +1     
==========================================
- Hits        32411    32409       -2     
- Misses       2577     2580       +3

Flag	Coverage Δ
e2e	`49.58% <100.00%> (+0.02%)`	⬆️
integration	`25.38% <0.00%> (-0.01%)`	⬇️
unit	`90.11% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rissson · 2024-07-04T13:59:06Z

Related to #9559?

BeryJu · 2024-07-04T14:13:16Z

Related to #9559?

Indeed, however then we lacked tests to make sure nothing else was affected

BeryJu · 2024-07-04T14:13:22Z

/cherry-pick version-2024.6

github-actions · 2024-07-04T14:28:51Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-05c67182d446a3038648cd7b4c4553634c4e7ba2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-05c67182d446a3038648cd7b4c4553634c4e7ba2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-05c67182d446a3038648cd7b4c4553634c4e7ba2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-05c67182d446a3038648cd7b4c4553634c4e7ba2-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

sources/oauth: fix link not being saved (#10374) Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>

* main: (350 commits) web: bump @swc/core from 1.6.6 to 1.6.7 in /web/sfe (#10395) web: bump @sentry/browser from 8.14.0 to 8.15.0 in /web in the sentry group across 1 directory (#10388) website/integrations: aws: cleanup (#10355) web: bump API Client version (#10389) web/flows: Simplified flow executor (#10296) website/docs: sources: ldap: remove extra example (#10387) website/docs: add new content from old PR #9524 (#10158) stages/authenticator_validate: fix friendly_name being required (#10382) core: bump go api client (#10383) web: bump API Client version (#10381) outposts: make refresh interval configurable (#10138) core, web: update translations (#10378) web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379) core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380) sources/oauth: fix link not being saved (#10374) website/docs: update postgres on docker: fix backtick (#10372) website/integrations: apache guacamole: cleanup doc page (#10354) web: bump API Client version (#10371) Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370) web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362) ...

* main: (29 commits) website/integrations: aws: cleanup (#10355) web: bump API Client version (#10389) web/flows: Simplified flow executor (#10296) website/docs: sources: ldap: remove extra example (#10387) website/docs: add new content from old PR #9524 (#10158) stages/authenticator_validate: fix friendly_name being required (#10382) core: bump go api client (#10383) web: bump API Client version (#10381) outposts: make refresh interval configurable (#10138) core, web: update translations (#10378) web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379) core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380) sources/oauth: fix link not being saved (#10374) website/docs: update postgres on docker: fix backtick (#10372) website/integrations: apache guacamole: cleanup doc page (#10354) web: bump API Client version (#10371) Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370) web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362) core: bump goauthentik.io/api/v3 from 3.2024060.2 to 3.2024060.3 (#10356) website: bump react-tooltip from 5.27.0 to 5.27.1 in /website (#10357) ...

sources/oauth: fix link not being saved

05c6718

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu requested a review from a team as a code owner July 4, 2024 13:52

rissson approved these changes Jul 4, 2024

View reviewed changes

BeryJu merged commit 3338a79 into main Jul 4, 2024

BeryJu deleted the sources/oauth/fix-link branch July 4, 2024 14:31

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 4, 2024

sources/oauth: fix link not being saved (#10374)

93f5edf

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

gcp-cherry-pick-bot bot mentioned this pull request Jul 4, 2024

sources/oauth: fix link not being saved (cherry-pick #10374) #10376

Merged

BeryJu added a commit that referenced this pull request Jul 4, 2024

sources/oauth: fix link not being saved (cherry-pick #10374) (#10376)

bfbab63

sources/oauth: fix link not being saved (#10374) Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sources/oauth: fix link not being saved#10374

sources/oauth: fix link not being saved#10374
BeryJu merged 1 commit intomainfrom
sources/oauth/fix-link

BeryJu commented Jul 4, 2024

Uh oh!

netlify bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jul 4, 2024 •

edited

Loading

Uh oh!

rissson commented Jul 4, 2024

Uh oh!

BeryJu commented Jul 4, 2024

Uh oh!

BeryJu commented Jul 4, 2024

Uh oh!

github-actions bot commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BeryJu commented Jul 4, 2024

Details

Checklist

Uh oh!

netlify bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

netlify bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs ready!

Uh oh!

codecov bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rissson commented Jul 4, 2024

Uh oh!

BeryJu commented Jul 4, 2024

Uh oh!

BeryJu commented Jul 4, 2024

Uh oh!

github-actions bot commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jul 4, 2024 •

edited

Loading

netlify bot commented Jul 4, 2024 •

edited

Loading

codecov bot commented Jul 4, 2024 •

edited

Loading