added int and []byte type to entry unmarshal#382
added int and []byte type to entry unmarshal#382cpuschma merged 3 commits intogo-ldap:masterfrom 4xoc:unmarshal-more-types
Conversation
|
Thank you for your PR! May you add support for int64 as well, as the go-asn1-ber supports up to 64 bits integers. I have been thinking about using the raw bytes instead of the already generated string to avoid additional type conversions, but this might blow up the code since we don't know how many bytes one attribute has.. Maybe in the future, when adding support for more (or even custom) types we should switch to |
|
Added int64 now too. Happy to add more builtin types, just started with the ones I need myself. |
cpuschma
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your PR! 🥰
I'll leave this PR open for a few days for other contributors to comment. I'll merge this if no one subjects.
Co-authored-by: xoc <xoc@4xoc.com>
Based on the ground work of #304 this PR adds two additional supported variable types: int and []byte.