Skip to content

Add Entry Unmarshal#304

Merged
cpuschma merged 10 commits intogo-ldap:masterfrom
clementblaise:master
Jun 22, 2022
Merged

Add Entry Unmarshal#304
cpuschma merged 10 commits intogo-ldap:masterfrom
clementblaise:master

Conversation

@clementblaise
Copy link
Contributor

@clementblaise clementblaise commented Jan 18, 2021

Add a decoding feature to Result Entry

@stefanmcshane
Copy link
Contributor

stefanmcshane commented Mar 30, 2021

Hi @clementblaise,
Apologies for the slow reply. Can you apply the changes to the relevant files in v3/ folder as well to ensure modules support?
Ill get this merged this weekend if possible.
Thanks,
Stefan

@clementblaise
Copy link
Contributor Author

clementblaise commented Apr 12, 2021

Hello @stefanmcshane, I have update the v3 folder

@cpuschma
Copy link
Member

cpuschma commented Apr 25, 2022

@clementblaise Thank you for this PR, I really like this feature! Maybe we can even add an unmarshal function for SearchResult in the future :)

Can you update your branch so we can get the conflict resolved and this PR merged? ☺️

@4xoc
Copy link
Contributor

4xoc commented Jun 3, 2022

When could we get this PR merged? This is very nice feature missing for a long time imho and I would very much like to see this part of this library.

@cpuschma
Copy link
Member

cpuschma commented Jun 8, 2022 •
edited
Loading

The Unmarshal method currently only supports exported fields of type string and []string, but this can be resolved in a PR without breaking any functionality/backwards compatibility. I added further documentation and error checking when filling the struct fields, this also allows us to later add more supported field types.

@cpuschma cpuschma requested a review from stefanmcshane June 8, 2022 21:34
@cpuschma cpuschma merged commit 05f81f7 into go-ldap:master Jun 22, 2022
@4xoc 4xoc mentioned this pull request Jun 25, 2022
Merged
inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
@clementblaise @stefanmcshane
@johnweldon @cpuschma @inv2004
Add Entry Unmarshal (go-ldap#304)
419c3d3 
Co-authored-by: Clément Blaise <blaise_c@prodgrp.local>
Co-authored-by: Stefan McShane <stefanmcshane@users.noreply.github.com>
Co-authored-by: John Weldon <johnweldon4@gmail.com>
Co-authored-by: Christopher Puschmann <cp@lumen.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanmcshane stefanmcshane Awaiting requested review from stefanmcshane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clementblaise @stefanmcshane @cpuschma @4xoc @johnweldon