Versioned v3 according to Go wiki, maintaining backward compatibility#247
Merged
johnweldon merged 2 commits intogo-ldap:masterfrom Nov 12, 2019
stefanmcshane:master
Merged
Versioned v3 according to Go wiki, maintaining backward compatibility#247johnweldon merged 2 commits intogo-ldap:masterfrom stefanmcshane:master
johnweldon merged 2 commits intogo-ldap:masterfrom
stefanmcshane:master
Conversation
…erted top level go.mod to fix backward compatibility
johnweldon
approved these changes
Nov 12, 2019
Member
johnweldon
left a comment
There was a problem hiding this comment.
LGTM - I'll merge when you update that README
Thank you.
hahmadia
added a commit
to mattermost/ldap
that referenced
this pull request
Nov 25, 2019
* unified request flow && external binding to LDAP (go-ldap#232) * unified request flow && external binding to LDAP * fix debug mode * go.mod was added * Prevent negative waitgroup panic by `Add`ing first. (go-ldap#237) * Use github for module name. (go-ldap#239) * Rename asn1 ber dependency. (go-ldap#243) * Rename asn1.ber dependency. * go mod tidy * Update travic CI to new asn1 ber * Update travis go_import_path * Update README (go-ldap#245) * Update go.mod (go-ldap#241) I believe that this (plus a new tag) is what is necessary for native go modules support -- right now go modules complains that the version tag is >= v2 but the module doesn't claim to be a version >= v2. * Versioned v3 according to Go wiki, maintaining backward compatibility (go-ldap#247) * Moved v3 to subfolder to allow for versioning >2 with go modules. Reverted top level go.mod to fix backward compatibility * Updated readme to include directions on Go Modules, including the rationale
cmurphy
added a commit
to cmurphy/rancher
that referenced
this pull request
Oct 19, 2021
Notes: - the v3 major release coincided with an update to use Go modules[1] but is an otherwise backwards-compatible release. It was not related to compatibility with the LDAP V3 protocol, the ldap.v2 package was already compatible with the LDAP V3 protocol. - the import path changed shortly after the v3 release[2], but it is the same package as before [1] go-ldap/ldap#247 [2] go-ldap/ldap@c135faa
MbolotSuse
pushed a commit
to MbolotSuse/rancher
that referenced
this pull request
Jan 5, 2022
Notes: - the v3 major release coincided with an update to use Go modules[1] but is an otherwise backwards-compatible release. It was not related to compatibility with the LDAP V3 protocol, the ldap.v2 package was already compatible with the LDAP V3 protocol. - the import path changed shortly after the v3 release[2], but it is the same package as before [1] go-ldap/ldap#247 [2] go-ldap/ldap@c135faa (cherry picked from commit 737ae12)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #246
Moved v3 to subdirectory to allow for versioning >2 with go modules.
Reverted top level go.mod to fix backward compatibility.
With Go Modules (
GO111MODULE=on):go get github.com/go-ldap/ldap/v3go get -u github.com/go-ldap/ldap/v3go get github.com/go-ldap/ldap/v3@v3.1.5.Without Go Modules, v3.0.3 will work (
GO111MODULE=off, or go version <1.13):go get github.com/go-ldap/ldapThis complies with one of the suggested versioning methods from: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
Ideally we would increase the versioning number (rename v3 directory to v4, and the go.mod to v4) however this would stray from the LDAPv3 coupling.
https://tools.ietf.org/html/rfc4511
EDIT: Formatting