Merged
Conversation
itslychee
approved these changes
Mar 11, 2024
|
hopefully this will get merged soon |
|
Saya nyahlanggan
Pada Sel, 31 Dis 2024, 6:31 PM Spencer Ferris ***@***.***>
menulis:
… Any chance this or one of the other duplicate PRs (1
<#4427>, 2
<#4469>) can be merged soon?
—
Reply to this email directly, view it on GitHub
<#4350 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMI7AEIJGLSZGWBEGQHUF4L2IJXA5AVCNFSM6AAAAABUNJPLWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGMZDINJXGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
This was referenced Jan 9, 2025
EliahKagan
added a commit
to EliahKagan/prodash
that referenced
this pull request
Jan 11, 2026
It was the default not to commit lockfiles for library-only crates, at the time `.gitignore` here was written. Since then, however: - rust-lang/cargo#12382 - github/gitignore#4350 More importantly, tracking `Cargo.lock` helps in improving supply chain security, in two ways: 1. A supply chain attack is less often immediately successful. 2. Further mitigations, such as dependency cooldown, can be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
The Cargo team no longer have definitive suggestion on whether you should ignore
Cargo.lock, and the previous description is now outdated.Links to documentation supporting these rule changes:
https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
https://doc.rust-lang.org/nightly/cargo/faq.html#why-have-cargolock-in-version-control