refactor(rust): always allow Cargo.lock file#4469
Closed
carlocorradini wants to merge 1 commit intogithub:mainfrom
Closed
refactor(rust): always allow Cargo.lock file#4469carlocorradini wants to merge 1 commit intogithub:mainfrom
carlocorradini wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
|
Closed by #4350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Rust advice for
Cargo.lockfile is to do whatever is best for their project.From
Rust nightly 2023-08-24, commandcargo newno longer ignoresCargo.lockfor libraries.Therefore, the
Cargo.lockfile should not be ignored.Links to documentation supporting these rule changes:
Official Rust Blog: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
Official Rust Doc: https://doc.rust-lang.org/nightly/cargo/faq.html#why-have-cargolock-in-version-control