Multiple Chart Enhancements and Bugfixes#938
Merged
gitbrent merged 1 commit intogitbrent:masterfrom May 17, 2021
Merged
Conversation
gitbrent
added a commit
that referenced
this pull request
May 17, 2021
Owner
|
Thank you very much @ReimaFrgos ! The backlog was becoming daunting. |
This was referenced May 17, 2021
Closed
gitbrent
added a commit
that referenced
this pull request
May 22, 2021
incowiahpe
pushed a commit
to incowiahpe/PptxGenJS
that referenced
this pull request
Jun 1, 2021
incowiahpe
added a commit
to incowiahpe/PptxGenJS
that referenced
this pull request
Jun 1, 2021
This reverts commit a6c3194.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses a number of the outstanding bugs and requests for working with Charts.
Issue #858 :
Issue #837 : This has already been patched. Patch is still in this release and issue should be able to be closed.
Issue #747 : Added support for catAxisMajorUnit and catAxisMinor unit to function correctly with double value axis chart types (Scatter Chart + Bubble Chart)
Issue #662 : Fixed issue for dataLabelFontBold to correctly bold data labels.
Issue #815 : This was an invalid input that should no longer be allowed after this PR
Issue #788 : This was an invalid input that should no longer be allowed after this PR
Issue #768 : This was an invalid input that should no longer be allowed after this PR
Additional Enhancements:
2.1. New configuration: catAxisLabelFontItalic
2.2. New configuration: serAxisLabelFontItalic
2.3. New configuration: valAxisLabelFontItalic
2.4. New configuration: dataLabelFontItalic
Additional Issues Reviewed, but not specifically in this release:
Issue #441 : This feature has already been implemented and should be safe to close.
Issue #291 : This feature has already been implemented and should be safe to close.
This PR replaces PR #794 which can be cancelled / closed
Everything has tested successfully against the full demo build.