Issues 788+768 - Validate dataLabelPosition is valid for charts#794
Closed
ReimaFrgos wants to merge 1 commit intogitbrent:masterfrom
Closed
Issues 788+768 - Validate dataLabelPosition is valid for charts#794ReimaFrgos wants to merge 1 commit intogitbrent:masterfrom
ReimaFrgos wants to merge 1 commit intogitbrent:masterfrom
Conversation
Owner
|
Closing: Superseded by Pull #938 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gitbrent this PR replaces #789 and updates the ./src/*.ts files instead.
(This is a resubmit because of a config issue)
Edits will override user actions with default settings if they try to enter an invalid input for either a dataLabelPosition or barGrouping value. barGrouping affects valid data labels which is why this is included.
This should resolve errors raised in:
#788 #768
It should also resolve issues relating to Office Online usage.
I have removed redundant validation that is no longer required when inserting the dataLabelPosition string
Have built the library through npm scripts > ships and outputted .js file runs successfully against all demo scripts. There is one minor change to bubble chart behaviour as seen in the Bubble Chart demo on Slide 15, bottom left. The data labels shift from center to right as per default MS Office behaviour. This could be addresses by either tweaking the edit to default this to Center, or update the demo too set the position to center depending on how sever you consider this impact.