Disable CGO for Centos 5 to assist #952#976
Merged
technoweenie merged 1 commit intogit-lfs:masterfrom Feb 4, 2016
Merged
Conversation
Contributor
|
Thanks, but now I realize it didn't affect the dockerfiles, since they're on docker hub :) Hopefully git-lfs/build-dockers#1 should work. |
technoweenie
added a commit
that referenced
this pull request
Feb 4, 2016
Disable CGO for Centos 5 to assist #952
Contributor
Author
|
This fix won't actually work apparently. |
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Jun 19, 2025
In commit 6006acc in PR git-lfs#976 we introduced a conditional build clause to the SPEC file use we to build RPM Linux packages, in an attempt to avoid compiling with cgo enabled on Red Hat Enterprise Linux (RHEL) 5 and CentOS 5 platforms. This change was made after the use of the "C" pseudo- module was introduced into the Git LFS client code in commit ea16fd5 of PR git-lfs#952, as part of our initial support for copy-on-write file creation. In practice, though, this conditional build clause was ineffective, according to the notes in PR git-lfs#976. Instead, one of the Dockerfiles used to build RPM packages for the RHEL/CentOS 5 platform was updated in commit git-lfs/build-dockers@39cec36 of PR git-lfs/build-dockers#1 to set the CGO_ENABLED environment variable with a value of "0". The conditional build clause in our SPEC file was never removed afterwards, however. Later, the Dockerfile in which the CGO_ENABLED environment variable was set was removed in commit git-lfs/build-dockers@d4c2fe6, and the primary Dockerfile used for building packages for the RHEL/CentOS 5 platform was then dropped in commit git-lfs/build-dockers@64a3a9f of PR #3. This followed the removal of the references to the RHEL/CentOS 5 platform from the scripts in our "dockers" directory in commit b560b85 of PR git-lfs#1298. As there is no value to retaining the conditional build clause for the RHEL/CentOS 5 platform in the SPEC file for our RPM packages, we simply remove it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.