Skip to content

disable cgo on centos 5#1

Merged
andyneff merged 1 commit intogit-lfs:masterfrom
technoweenie:centos5-no-cgo
Feb 4, 2016
Merged

disable cgo on centos 5#1
andyneff merged 1 commit intogit-lfs:masterfrom
technoweenie:centos5-no-cgo

Conversation

@technoweenie
Copy link
Contributor

This should disable cgo for the lfs docker gauntlet on centos 5. I think :)

andyneff added a commit that referenced this pull request Feb 4, 2016
@andyneff andyneff merged commit 1a418da into git-lfs:master Feb 4, 2016
@technoweenie technoweenie deleted the centos5-no-cgo branch February 4, 2016 16:39
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Jun 19, 2025
In commit 6006acc in PR git-lfs#976 we
introduced a conditional build clause to the SPEC file use we to
build RPM Linux packages, in an attempt to avoid compiling with
cgo enabled on Red Hat Enterprise Linux (RHEL) 5 and CentOS 5
platforms.  This change was made after the use of the "C" pseudo-
module was introduced into the Git LFS client code in commit
ea16fd5 of PR git-lfs#952, as part of
our initial support for copy-on-write file creation.

In practice, though, this conditional build clause was ineffective,
according to the notes in PR git-lfs#976.  Instead, one of the Dockerfiles
used to build RPM packages for the RHEL/CentOS 5 platform was updated
in commit git-lfs/build-dockers@39cec36
of PR git-lfs/build-dockers#1 to set the CGO_ENABLED environment
variable with a value of "0".

The conditional build clause in our SPEC file was never removed
afterwards, however.  Later, the Dockerfile in which the CGO_ENABLED
environment variable was set was removed in commit
git-lfs/build-dockers@d4c2fe6,
and the primary Dockerfile used for building packages for the
RHEL/CentOS 5 platform was then dropped in commit
git-lfs/build-dockers@64a3a9f
of PR #3.  This followed the removal of the references to the
RHEL/CentOS 5 platform from the scripts in our "dockers" directory in
commit b560b85 of PR git-lfs#1298.

As there is no value to retaining the conditional build clause
for the RHEL/CentOS 5 platform in the SPEC file for our RPM packages,
we simply remove it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants