Replace unused debug mode with trace logging#5989
Merged
chrisd8088 merged 1 commit intogit-lfs:mainfrom Feb 14, 2025
Merged
Conversation
In PR git-lfs#68 the "commands" package was updated with several logging functions such as Panic(), Print(), and Debug(). The last of these only outputs a log message if the Debugging variable in the same package is set to "true", which at the time was controlled by the setupDebugging() function. If the user supplied the --debug option to a given Git LFS command, setupDebugging() function would set the Debugging variable to "true", and any calls to Debug() would then generate log messages. However, the setupDebugging() function was removed, along with a lot of the earlier command-line parsing and setup code, in PR git-lfs#84, and replaced with the Cobra library from the spf13/cobra project. Since then it has not been possible to set the Debugging variable to a value other than "false", so the remaining references to the Debug() function will never generate log messages. We therefore remove the Debugging variable and the Debug() function, and replace any calls to that function with ones to our standard trace logging function.
larsxschneider
approved these changes
Feb 14, 2025
| Panic(err, tr.Tr.Get("Unable to move %s to %s", tmpfile, mediafile)) | ||
| } | ||
|
|
||
| Debug(tr.Tr.Get("Writing %s", mediafile)) |
Member
There was a problem hiding this comment.
We don't want to translate these messages because it is debug output?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #68 the
commandspackage was updated with several logging functions such asPanic(),Print(), andDebug(). The last of these only outputs a log message if theDebuggingvariable in the same package is set totrue, which at the time was controlled by thesetupDebugging()function. If the user supplied the--debugoption to a given Git LFS command,setupDebugging()function would set theDebuggingvariable totrue, and any calls toDebug()would then generate log messages.However, in PR #84 the
setupDebugging()function was removed, along with a lot of the earlier command-line parsing and setup code, and replaced with the Cobra library from thespf13/cobraproject. Since then it has not been possible to set theDebuggingvariable to a value other thanfalse, so the remaining references to theDebug()function will never generate log messages.We therefore remove the
Debuggingvariable and theDebug()function, and replace any calls to that function with ones to our standard trace logging function.This change should help reduce the number of non-constant format strings we need to revise before adopting Go 1.24, as has been reported in #5968.