Skip to content

Go 1.24: non-constant format strings break test build #5968

@QuLogic

Description

@QuLogic

Describe the bug
We are rebuilding things in Fedora for upcoming version 42 against Go 1.24~rc1. go test fails on git-lfs due to non-constant format strings:

./command_clean.go:85:9: non-constant format string in call to github.com/git-lfs/git-lfs/v3/commands.Debug
./command_dedup.go:132:31: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_fsck.go:173:10: non-constant format string in call to github.com/git-lfs/git-lfs/v3/commands.Debug
./command_fsck.go:217:8: non-constant format string in call to github.com/git-lfs/git-lfs/v3/commands.Debug
./command_logs.go:40:8: non-constant format string in call to github.com/git-lfs/git-lfs/v3/commands.Debug
./command_logs.go:54:8: non-constant format string in call to github.com/git-lfs/git-lfs/v3/commands.Debug
./command_logs.go:55:77: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Wrapf
./command_migrate.go:322:29: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_export.go:38:31: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_export.go:119:31: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:47:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:51:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:69:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:76:33: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:83:37: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Wrapf
./command_migrate_import.go:127:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:145:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:398:30: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:436:30: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_import.go:458:29: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_info.go:99:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_info.go:106:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_migrate_info.go:109:32: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_pointer.go:132:26: non-constant format string in call to fmt.Fprintf
./command_smudge.go:48:5: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf
./command_smudge.go:111:5: non-constant format string in call to github.com/git-lfs/git-lfs/v3/errors.Errorf

To Reproduce
Test with Go 1.24 using go test.

Expected behavior
Tests build and work.

System environment
Fedora Rawhide
Go 1.24~rc1

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions