Merged
Conversation
commands/command_path.go
Outdated
Contributor
Author
There was a problem hiding this comment.
I'm not crazy about having a command alias like this. I'd prefer path. Maybe cobra has an easy alias thing though.
Contributor
Author
|
This was easier than I thought. I hate to drop a big PR and LEAVE, so I'll let you decide to merge it or not. |
Contributor
Author
|
Breaking changes (before I forget):
|
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 12, 2025
In PR git-lfs#68 the "commands" package was updated with several logging functions such as Panic(), Print(), and Debug(). The last of these only outputs a log message if the Debugging variable in the same package is set to "true", which at the time was controlled by the setupDebugging() function. If the user supplied the --debug option to a given Git LFS command, setupDebugging() function would set the Debugging variable to "true", and any calls to Debug() would then generate log messages. However, the setupDebugging() function was removed, along with a lot of the earlier command-line parsing and setup code, in PR git-lfs#84, and replaced with the Cobra library from the spf13/cobra project. Since then it has not been possible to set the Debugging variable to a value other than "false", so the remaining references to the Debug() function will never generate log messages. We therefore remove the Debugging variable and the Debug() function, and replace any calls to that function with ones to our standard trace logging function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been wanting to play with cobra for awhile. It gives us posix compatible flag handling, and an automatic help command.
A lot of the files are part of the vendored libs. Skip all that noise.