Merged
Conversation
In commit f4ab4e7 of PR git-lfs#4883 we noted that the "gem install ronn" step in our Windows CI workflows currently fails on newer Windows Server 2022 GitHub Actions runners, due to possibly some missing C headers or libraries. While this could be resolved by upgrading to the "ruby/setup-ruby" action from the deprecated "actions/setup-ruby" one, that introduced a series of issues with PATH lookups as documented in ruby/setup-ruby#293. We therefore chose to continue using Windows 2019 runners until a resolution or workaround was found. Fortunately, as of commit 912b607 in PR git-lfs#4992 we are now using the ronn-ng Ruby gem instead of the unmaintained ronn gem, and the "gem install ronn-ng" workflow step succeeds on Windows 2022 while still using the "actions/setup-ruby" action to install a Ruby build environment. This allows us to upgrade to the latest Windows runners in GitHub Actions, although we can't yet upgrade to the "ruby/setup-ruby" workflow action. h/t to @bk2204 for finding ronn-ng!
bk2204
approved these changes
May 10, 2022
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Aug 6, 2022
With the migration of our manual pages to AsciiDoctor in PR git-lfs#5054 we can now upgrade to the ruby/setup-ruby@v1 action instead of using the deprecated and unmaintained actions/setup-ruby@v1 action. BUT -- PATH on Windows ... see 6c234a2 and pull request git-lfs#4997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit f4ab4e7 of PR #4883 we noted that the
gem install ronnstep in our Windows CI workflows currently fails on newer Windows Server 2022 GitHub Actions runners, due to possibly some missing C headers or libraries.While this could be resolved by upgrading to the
ruby/setup-ruby@v1action from the deprecatedactions/setup-ruby@v1one, that introduced a series of issues withPATHlookups as documented in ruby/setup-ruby#293.We therefore chose to continue using Windows 2019 runners until a resolution or workaround was found.
Fortunately, as of commit 912b607 in PR #4992 we are now using the
ronn-ngRuby gem instead of the unmaintainedronngem, and thegem install ronn-ngworkflow step succeeds on Windows 2022 while still using theactions/setup-ruby@v1action to install a Ruby build environment. This allows us to upgrade to the latest Windows runners in GitHub Actions, although we can't yet upgrade to theruby/setup-ruby@v1workflow action.h/t to @bk2204 for finding ronn-ng!
Resolves #4995.