Skip to content

Bump Go version and drop obsolete OS images#33

Merged
bk2204 merged 2 commits intogit-lfs:masterfrom
bk2204:latest-go-version
Dec 1, 2020
Merged

Bump Go version and drop obsolete OS images#33
bk2204 merged 2 commits intogit-lfs:masterfrom
bk2204:latest-go-version

Conversation

@bk2204
Copy link
Member

@bk2204 bk2204 commented Dec 1, 2020

Let's bump the Go version to 1.15.5, which is the latest, and drop support for obsolete OS versions that are no longer supported.

Both CentOS 6 and Debian 8 are now EOL.  Let's stop building images for
them.
Bump Go to the latest version, 1.15.5, and update the SHA-256 checksums.
@bk2204 bk2204 requested a review from a team December 1, 2020 16:57
Copy link
Collaborator

@andyneff andyneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL 6 could have 4 more years of ELS support (past normal EOL), but I think it's fair to drop it.

Copy link
Member

@chrisd8088 chrisd8088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bk2204 bk2204 merged commit c3fe368 into git-lfs:master Dec 1, 2020
@bk2204 bk2204 deleted the latest-go-version branch December 1, 2020 19:28
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we
introduced support for CentOS 6 into our rpm/build_rpms.bsh script by
building an early version of Git from a local git.spec file.  Then in
commit d2d90a8 of PR git-lfs#891 this was
replaced with installation from the setup.ius.io service.

In commit git-lfs/build-dockers@7af5552
of PR git-lfs/build-dockers#19, however, the download and installation
of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later
this was adjusted to download from kernel.org.

In commit git-lfs/build-dockers@f1f573f
of PR git-lfs/build-dockers#29 we added support for CentOS 8, which
supports a direct installation of Git using yum.

And in commit git-lfs/build-dockers@898d9b0
of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely.

Therefore we no longer have any need for our rpm/build_rpms.bsh script
to install Git at all, especially not very old versions, so we simply
remove that logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we
introduced support for CentOS 6 into our rpm/build_rpms.bsh script by
building an early version of Git from a local git.spec file.  Then in
commit d2d90a8 of PR git-lfs#891 this was
replaced with installation from the setup.ius.io service.

In commit git-lfs/build-dockers@7af5552
of PR git-lfs/build-dockers#19, however, the download and installation
of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later
this was adjusted to download from kernel.org.

In commit git-lfs/build-dockers@f1f573f
of PR git-lfs/build-dockers#29 we added support for CentOS 8, which
supports a direct installation of Git using yum.

And in commit git-lfs/build-dockers@898d9b0
of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely.

Therefore we no longer have any need for our rpm/build_rpms.bsh script
to install Git at all, especially not very old versions, so we simply
remove that logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
In commit cd3e92e of PR git-lfs#480 we
introduced support for CentOS 6 into our rpm/build_rpms.bsh script by
building an early version of Git from a local git.spec file.  Then in
commit d2d90a8 of PR git-lfs#891 this was
replaced with installation from the setup.ius.io service.

In commit git-lfs/build-dockers@7af5552
of PR git-lfs/build-dockers#19, however, the download and installation
of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later
this was adjusted to download from kernel.org.

In commit git-lfs/build-dockers@f1f573f
of PR git-lfs/build-dockers#29 we added support for CentOS 8, which
supports a direct installation of Git using yum.

And in commit git-lfs/build-dockers@898d9b0
of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely.

Therefore we no longer have any need for our rpm/build_rpms.bsh script
to install Git at all, especially not very old versions, so we simply
remove that logic from our script.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
We no longer support either CentOS 5 or 6, per commit
b560b85 of PR git-lfs#1298 and commit
git-lfs/build-dockers@64a3a9f
of PR git-lfs/build-dockers#3, and commit
git-lfs/build-dockers@898d9b0
of PR git-lfs/build-dockers#33.

We also now build the Asciidoctor Ruby gem in order to generate
our man pages, rather than using ronn and several other gems,
per commit db9a821 of PR git-lfs#5054.

We therefore update the documentation for our RPM package build
utilities and for our Docker container image build utilities to
reflect these changes.
chrisd8088 added a commit to chrisd8088/git-lfs that referenced this pull request Dec 28, 2022
We no longer support either CentOS 5 or 6, per commit
b560b85 of PR git-lfs#1298 and commit
git-lfs/build-dockers@64a3a9f
of PR git-lfs/build-dockers#3, and commit
git-lfs/build-dockers@898d9b0
of PR git-lfs/build-dockers#33.

We also now build the Asciidoctor Ruby gem in order to generate
our man pages, rather than using ronn and several other gems,
per commit db9a821 of PR git-lfs#5054.

We therefore update the documentation for our RPM package build
utilities and for our Docker container image build utilities to
reflect these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants