Merged
Conversation
CentOS 8 is now released and has Docker images, so build a Docker image for it.
Collaborator
|
Why is the |
Member
Author
|
It wouldn't run except with as yet unmerged code, since the RPM build process would fail for anything but the latest version. And as mentioned in the comment, I'm fine with restoring it after the first release, although I'm also fine with not doing so, since when we build on GitHub Actions, we don't cache the Docker images: we build them once and use them once. |
Collaborator
|
That's a good point, without docker cache there is no benefit. |
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 27, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Dec 28, 2022
In commit cd3e92e of PR git-lfs#480 we introduced support for CentOS 6 into our rpm/build_rpms.bsh script by building an early version of Git from a local git.spec file. Then in commit d2d90a8 of PR git-lfs#891 this was replaced with installation from the setup.ius.io service. In commit git-lfs/build-dockers@7af5552 of PR git-lfs/build-dockers#19, however, the download and installation of Git 2.16 from github.com was added to the CentOS 6 Dockerfile; later this was adjusted to download from kernel.org. In commit git-lfs/build-dockers@f1f573f of PR git-lfs/build-dockers#29 we added support for CentOS 8, which supports a direct installation of Git using yum. And in commit git-lfs/build-dockers@898d9b0 of PR git-lfs/build-dockers#33 we dropped support for CentOS 6 entirely. Therefore we no longer have any need for our rpm/build_rpms.bsh script to install Git at all, especially not very old versions, so we simply remove that logic from our script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CentOS 8 is now released and has Docker images, so build a Docker image for it.