release: migrate .net tool off esrp #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate .NET tool from using ESRP to using the Sign CLI tool for signing. This tool is a fork of [1] that was set up to support Trusted Signing (previously known as Azure Code Signing). 1: https://github.com/dotnet/sign
Remove ESRP-related scripts, as we are no longer using this tool for signing.
mjcheetham
approved these changes
Apr 8, 2024
|
@ldennington thanks for that information. When I feel I have so much to learn when it comes to codes itself, I see it's still so much deeper than that. Obtaining a lot since being here! |
Merged
mjcheetham
added a commit
that referenced
this pull request
Apr 16, 2024
**Changes:** - Fixes to install from source script (#1469) - Use Avalonia generated view code (#14790 - Various GitHub Actions updates (#1473, #1483, #1487, #1486, #1488, #1528, #1547) - Fix bug in Azure Repos URL handling (#1522) - Add Azure Managed Identity and SP docs (#1548) - Fix error messages when using GCM outside of repo (#1561, #1583) - Remove ESRP (#1571) - Update to .NET 8 for Mac and Linux (#1579, #1580) - Fix Alpine install from source script (#1582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates .NET tool payload/package signing to use the Sign CLI tool instead of ESRP. The most significant changes include the addition of a new step to download/extract the Sign CLI tool from Azure Blob Storage, the modification of signing steps to use the downloaded tool, and the removal of ESRP-related scripts.
Benefits
Migrating away from ESRP comes with the following major benefits:
Testing
I have successfully completed two end-to-end runs of the
releaseworkflow with these updates in my fork.Details
Changes to the release workflow:
.github/workflows/release.yml: Zipping/unzipping steps for the unsigned payload and package were removed. The setup and running of the ESRP client were replaced with the downloading and extraction of the Sign CLI tool and the signing of the payload and package using this tool.Scripts removed:
.github/run_esrp_signing.py: The entire Python script for running the ESRP client has been removed..github/set_up_esrp.ps1: The PowerShell script for setting up the ESRP client has been removed.