Make install script compliant #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
approved these changes
Nov 7, 2023
Contributor
mjcheetham
left a comment
There was a problem hiding this comment.
Good catch! Thank you
vdye
approved these changes
Nov 7, 2023
Contributor
vdye
left a comment
There was a problem hiding this comment.
Thanks for the fix @Mycobee! This looks good to me, but I've tagged @mjcheetham (GCM's maintainer) to make sure I'm not missing something.
Merged
mjcheetham
added a commit
that referenced
this pull request
Apr 16, 2024
**Changes:** - Fixes to install from source script (#1469) - Use Avalonia generated view code (#14790 - Various GitHub Actions updates (#1473, #1483, #1487, #1486, #1488, #1528, #1547) - Fix bug in Azure Repos URL handling (#1522) - Add Azure Managed Identity and SP docs (#1548) - Fix error messages when using GCM outside of repo (#1561, #1583) - Remove ESRP (#1571) - Update to .NET 8 for Mac and Linux (#1579, #1580) - Fix Alpine install from source script (#1582)
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lack of space breaks the script on some less featured shells. This commit fixes it