Skip to content

Cs fix#1

Merged
ggppdk merged 1 commit intoggppdk:patch-3from
wojsmol:10753-cs
Jun 8, 2016
Merged

Cs fix#1
ggppdk merged 1 commit intoggppdk:patch-3from
wojsmol:10753-cs

Conversation

@wojsmol
Copy link
Copy Markdown

@wojsmol wojsmol commented Jun 7, 2016

Pull Request for joomla#10753

@ggppdk ggppdk merged commit 80a5498 into ggppdk:patch-3 Jun 8, 2016
@wojsmol wojsmol deleted the 10753-cs branch June 8, 2016 09:46
ggppdk pushed a commit that referenced this pull request Jun 18, 2016
Unit test loading behavior, don't explicitly import JFactory now
ggppdk pushed a commit that referenced this pull request Dec 21, 2016
… (joomla#12290)

* Cleanups, fixes and a bit of optimizations for site/components batch #1

- com_ajax
- com_banners
- com_config
Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Ch-Ch-Changes!

* Removed the query changes

* Fix for wrong merge resolve
ggppdk pushed a commit that referenced this pull request Dec 21, 2016
…otes-in-administrator-no-1

Replace unnecessary double quotes in administrator #1
Bakual pushed a commit that referenced this pull request Jan 14, 2017
- removed senseless statements
- one case correction
- one loop optimization
- removed a closing tag
Bakual pushed a commit that referenced this pull request Jan 14, 2017
ggppdk pushed a commit that referenced this pull request May 11, 2017
)

* Update site.php

* Update site.php

* Update site.php

* Update site.php

* Move unset into the else condition
ggppdk pushed a commit that referenced this pull request Jun 17, 2017
* Fixed callable call in loop termination condition

* Fixed non-optimal regular expression

* Shortened syntax for applied operations

* Don't use strlen() to check if string is empty.

* Reverted preg changes. Look into those later again.

* Replaced call_user_func_array() with call_user_func()

* Merge unset() calls

* Replaced old intval() call with modern typecasting

* Optimize away substr() as index-based access

* Replace some cases of substr() with strpos()

* Replace some stristr() with stripos()

* Replace is_null() with null === ...

* Removed unnecessary ternary operators

* Fix for Juri...

* Revert some changes for ... PHP5.3 compatibility

* Make travis happy ....

* Make codesniffer happy...

* DYC!

* Optimize non-optimal if conditions.

* codsniffer...

* Inline one-time use variables

* Codesniffer...

* Flipped comparisons
`null === ...`  to Joomla Style `... === null`
`null !== ...`  to Joomla Style `... !== null`

* Flipped comparisons
`false !== ...`  to Joomla Style `... !== falsel`

* Fix removal of ternary operator. Forgot inversion.

* More flipping of  comparisons ;)

* Removed another unnecessary set of ternary operators.

* Codesniffer...

* Type-safe comparisons on strings

* More type-safe comparisons

* Changes that occurred during PR discussion

* Remove some unnecessary parentheses

* Removed empty if-group and reversed condition

* Corrections on errors during merge (Conflict resolving)

* Missed one.

* Remove a parenthesis

* Changes according to reviewer's comment

* Revert change because of failure

* Changes according to reviewer's comment
+ a few more changes found last minute

* reversed change, though according to the method's doc that value should have been an integer...

* Hopefully fixed...

* Hopefully fixed...

* Re-apply some changes
ggppdk pushed a commit that referenced this pull request Sep 10, 2018
Add missing string COM_PRIVACY_MSG_CONSENT_NO_CONSENT
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…oomla#36804)

Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…ssing null to type string (joomla#36795)

* [3.10] [PHP 8.1] fixes mod_tags_popular

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`

* [3.10] [PHP 8.1] fixes mod_breadcrumbs

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`

* Update mod_custom.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

* [3.10] [PHP 8.1] Fixes mod_menu.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

* [3.10] [PHP 8.1] mod_stats

* [3.10] [PHP 8.1] fixes mod_articles_archive.php

* [3.10] [PHP 8.1] mod_articles_categories.php

* [3.10] [PHP 8.1] fixes mod_articles_category

* [3.10] [PHP 8.1] fixes mod_articles_latest

* [3.10] [PHP 8.1] fixes mod_articles_news

* [3.10] [PHP 8.1] fixes mod_articles_popular

* [3.10] [PHP 8.1] fixes mod_banners

* [3.10] [PHP 8.1] fixes mod_feed

* [3.10] [PHP 8.1] fixes mod_footer

* [3.10] [PHP 8.1] fixes mod_languages

* [3.10] [PHP 8.1] fixes mod_random_image

* [3.10] [PHP 8.1] fixes mod_related_items

* [3.10] [PHP 8.1] fixes mod_syndicate

* [3.10] [PHP 8.1] fixes mod_tags_similar

* [3.10] [PHP 8.1] fixes mod_users_latest

* [3.10] [PHP 8.1] fixes mod_whosonline

* [3.10] [PHP 8.1] fixes mod_wrapper

* [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard

* [3.10] [PHP 8.1] fixes admin mod_feed

* [3.10] [PHP 8.1] fixes admin mod_stats_admin
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…tible (joomla#36794)

* [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)

* [3.10] [PHP 8.1] Fixes protostar modules.php null string param

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`

* [3.10] [PHP 8.1] Fixes beez modules.php null string param

Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…a#36792)

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…oomla#36799)

Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login
laoneo pushed a commit that referenced this pull request Mar 24, 2022
Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286`
and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…36777)

* [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

* [PHP 8.1] Editor in backend: Better fix for joomla#36777

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…oomla#36773)

* [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string

Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383`

* [PHP 8.1] admin mod_menu: Slightly cleaner fix for joomla#36773
laoneo pushed a commit that referenced this pull request Mar 24, 2022
* [3.10] [PHP 8.1] Fixes com_finder/indexer/query

Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733`

* Better fix for joomla#36796 as suggested by @zero-24
laoneo pushed a commit that referenced this pull request Mar 24, 2022
…strpos() (joomla#36798)

* [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos()

Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124`

* [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Revert previous commit for different fix in mod_breadcrumbs/helper.php

* [PHP 8.1] Better fix for joomla#36798 mod_breadcrumbs with null link in last item

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants