Merged
Conversation
Contributor
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Sep 2, 2020
917: Patch 0.6.1 r=straightforward a=kvark **Connections** Closes #905 Includes #916 **Description** Just back-porting the fixes from master **Testing** playtested only Co-authored-by: Nathan Adams <dinnerbone@dinnerbone.com> Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com> Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Sep 2, 2020
548: wgpu update with correctness fixes r=kvark a=kvark Picks up a few important correctness fixes, such as gfx-rs/wgpu#916 and gfx-rs/wgpu#912 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
548: wgpu update with correctness fixes r=kvark a=kvark Picks up a few important correctness fixes, such as gfx-rs#916 and gfx-rs#912 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
916: Update capture API r=kvark a=kvark Picks up gfx-rs#1401 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Related to gfx-rs/gfx#3362
With the new use of
write_buffer/write_texture, the results on D3D11 regressed.Description
It just happened to be the case that all the backends returned coherent staging buffers, used internally for
write_*andmapped_at_creation == true. However, D3D11 backend currently doesn't have the coherent memory at all, and it helped me to see that we were missing a flush() on the staging buffer.Testing
Untested, but should work (tm).