Make player automatically start/stop the capture#1401
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom May 18, 2021
Merged
Make player automatically start/stop the capture#1401bors[bot] merged 1 commit intogfx-rs:masterfrom
bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 18, 2021
1401: Make player automatically start/stop the capture r=kvark a=kvark **Connections** Follow-up to #1301 **Description** Replaying compute-based workloads, or Gecko-based API traces, always wants to auto-capture everything. This PR makes it the default. **Testing** Tested on a real Gecko capture :) Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
Contributor
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
May 19, 2021
916: Update capture API r=kvark a=kvark Picks up gfx-rs/wgpu#1401 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
916: Update capture API r=kvark a=kvark Picks up gfx-rs#1401 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Follow-up to #1301
Description
Replaying compute-based workloads, or Gecko-based API traces, always wants to auto-capture everything.
This PR makes it the default.
Testing
Tested on a real Gecko capture :)