Add mip level count and array layer count validation to texture_create_view#844
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jul 29, 2020
Merged
Add mip level count and array layer count validation to texture_create_view#844bors[bot] merged 1 commit intogfx-rs:masterfrom
bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
kvark
requested changes
Jul 28, 2020
Contributor
Author
|
I have tested with |
Contributor
Author
|
I'll rebase this once #846 gets merged |
kvark
requested changes
Jul 28, 2020
Contributor
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
844: Update wgpu to the cross feature fix r=kvark a=kvark Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Catches the error when
mip_level_count = 0andbase_mip_level > texture.mip_level_count(same witharray_layer_count)Testing
Explain how this change is tested.
Haven't been tested yet