Make level and layer count for texture view optional#846
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jul 29, 2020
Merged
Make level and layer count for texture view optional#846bors[bot] merged 1 commit intogfx-rs:masterfrom
bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
cwfitzgerald
requested changes
Jul 28, 2020
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Looks great, a couple of docs fixes needed, but otherwise good.
Member
Author
|
Does are updated |
Contributor
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jul 29, 2020
488: Update wgpu with view descriptor changes r=kvark a=kvark Includes gfx-rs/wgpu#846 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
488: Update wgpu with view descriptor changes r=kvark a=kvark Includes gfx-rs#846 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
implements gpuweb/gpuweb#945
Description
NonZeroU32is more idiomatic hereTesting
untested, but should work