adds size function for VertexFormat#802
Merged
bors[bot] merged 2 commits intogfx-rs:masterfrom Jul 16, 2020
bootra-dev:vertex-format-size
Merged
adds size function for VertexFormat#802bors[bot] merged 2 commits intogfx-rs:masterfrom bootra-dev:vertex-format-size
bors[bot] merged 2 commits intogfx-rs:masterfrom
bootra-dev:vertex-format-size
Conversation
Contributor
Author
|
Woops, I forgot to change the default commit message -_- |
kvark
requested changes
Jul 16, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
Thank you!
please change the commit message and maybe address the suggestion
Member
|
Oh, another thing - can we remove the https://github.com/gfx-rs/wgpu-rs/blob/9f868cd2cba28db334f25272f672bd05e3e52866/src/macros.rs#L37 macro and just call the function you are adding instead? |
Contributor
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jul 21, 2020
442: replace vertex_format_size macro with VertexFormat size function r=kvark a=bootra-dev This pull request depends on gfx-rs/wgpu#802 I'm not sure if multiple pull requests is the right way to handle this - let me know if I need to use another workflow. Co-authored-by: bootra-dev <bootragames@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
442: replace vertex_format_size macro with VertexFormat size function r=kvark a=bootra-dev This pull request depends on gfx-rs#802 I'm not sure if multiple pull requests is the right way to handle this - let me know if I need to use another workflow. Co-authored-by: bootra-dev <bootragames@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #801
This PR adds a simple size function to the VertexFormat enum. It returns a u64 so that it can be conveniently used with the VertexAttributeDescriptor offset.