Fix cmd buffer cleanup not always using lowest active index#442
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jan 8, 2020
LaylBongers:master
Merged
Fix cmd buffer cleanup not always using lowest active index#442bors[bot] merged 1 commit intogfx-rs:masterfrom LaylBongers:master
bors[bot] merged 1 commit intogfx-rs:masterfrom
LaylBongers:master
Conversation
kvark
approved these changes
Jan 8, 2020
Member
kvark
left a comment
There was a problem hiding this comment.
Looks reasonable, thank you!
bors r+
bors bot
added a commit
that referenced
this pull request
Jan 8, 2020
442: Fix cmd buffer cleanup not always using lowest active index r=kvark a=LaylConway This fixes the index picked for cleanup not always being the lowest index. Additionally this fixes command buffers not being cleaned up if there are no active submissions, because in that case 0 would be picked, which resulted in nothing being cleaned up. Now instead if there are no active submissions, usize MAX will be picked. Fixes #441 Co-authored-by: Layl <2385329-layl@users.noreply.gitlab.com>
Contributor
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
442: replace vertex_format_size macro with VertexFormat size function r=kvark a=bootra-dev This pull request depends on gfx-rs#802 I'm not sure if multiple pull requests is the right way to handle this - let me know if I need to use another workflow. Co-authored-by: bootra-dev <bootragames@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the index picked for cleanup not always being the lowest index.
Additionally this fixes command buffers not being cleaned up if there are no active submissions, because in that case 0 would be picked, which resulted in nothing being cleaned up. Now instead if there are no active submissions, usize MAX will be picked.
Fixes #441