Nuke MTLTexture so we can get drawables again.#75
Closed
seivan wants to merge 2 commits intogfx-rs:masterfrom
seivan:patch-1
Closed
Nuke MTLTexture so we can get drawables again.#75seivan wants to merge 2 commits intogfx-rs:masterfrom seivan:patch-1
seivan wants to merge 2 commits intogfx-rs:masterfrom
seivan:patch-1
Conversation
Cached values were never destroyed, making the finite drawable pools dry. Temporary solution until a better one comes along, but fixes iOS issues for now.
kvark
requested changes
Feb 25, 2019
Member
kvark
left a comment
There was a problem hiding this comment.
Actually, sorry, I don't think we can do this just that straightforward...
If a framebuffer is in use by GPU, we can't remove it at this stage.
Contributor
Author
|
@kvark I see and totally understand - it's a hack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached values were never destroyed, making the finite drawable pools dry.
Temporary solution until a better one comes along, but fixes iOS issues for now.