[wgsl-in, wgsl-out, glsl-in] WebGPU compliant dual source blending feature#7146
Merged
Wumpf merged 6 commits intogfx-rs:trunkfrom Mar 8, 2025
Merged
[wgsl-in, wgsl-out, glsl-in] WebGPU compliant dual source blending feature#7146Wumpf merged 6 commits intogfx-rs:trunkfrom
Wumpf merged 6 commits intogfx-rs:trunkfrom
Conversation
d101739 to
ccbb722
Compare
b14e3e1 to
a15afa0
Compare
a15afa0 to
615acda
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
I've done some significant reviewing today, and I intend to finish on my Monday. Looking mostly good so far, with most of my nits on diagnostics. 🙂 |
Member
|
Sigh, I haven't been able to finish this review because of some resource conflicts in other parts of my day job and personal life. I do intend to finish this soon, though. |
14585a9 to
66bcdf3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
66bcdf3 to
ec47c29
Compare
ErichDonGubler
approved these changes
Mar 6, 2025
Member
There was a problem hiding this comment.
Approving, conditional on outstanding conversations being resolved. Since most conversations should be resolvable without code changes here directly, I want to unblock merging.
I used Conventional Comments in this review! I hope they help with clarity and tone. 🙂
6ad7bd8 to
9a0c1e1
Compare
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
…ature (gfx-rs#7146) Makes the dual source implementation in wgpu WebGPU spec compliant. Furthermore, makes the dual source blending extension available when targeting WebGPU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
CHANGELOGa bit #7274impl From<ImplementedEnableExtension> for EnableExtension#7275enableextensions #7276Description
Makes the dual source implementation in wgpu WebGPU spec compliant.
This means changing the wgsl syntax & associated validation to match what's described here and here and here.
Furthermore, makes the dual source blending extension available when targeting WebGPU.
In order to reliably test wgsl output I incorrectly assumed that the way to go would be to add a glsl input to the snapshot tests (mostly to check for the
enabledirective being written out correctly), didn't realize that there's wgsl->wgsl snapshot testing as well, so I ended up implementing glslindexparsing as collateral😄Testing
Added a slew of naga tests. Did manual testing in a pet project against native & WebGPU
Draft TODO
[help wanted] [partially orthogonal]: While trying this out on my pet project I couldn't get it to fly in WebGPU because I was using naga_oil (with a hack, see also Support wgsl diagnostic directives. bevyengine/naga_oil#113 (comment)) where I have to rely onModule->write_wgslwhich right now ignores all directives 😱 . Fixing that isn't entirely straight forward sinceModuleis language agnostic so I have to detect the need for thoseChecklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.