Merged
Conversation
ErichDonGubler
commented
Mar 6, 2025
Comment on lines
-176
to
-185
| ##### Refactored internal trace path parameter | ||
|
|
||
| Refactored some functions to handle the internal trace path as a string to avoid possible issues with `no_std` support. | ||
|
|
||
| By @brodycj in [#6924](https://github.com/gfx-rs/wgpu/pull/6924). |
Member
Author
There was a problem hiding this comment.
note: Removing this because this isn't a user-facing change. CC @brody4hire (for whom I think we had the wrong handle here to begin with?).
ErichDonGubler
commented
Mar 6, 2025
Comment on lines
+131
to
+139
| #### Split up `Features` internally | ||
|
|
||
| Internally split up the `Features` struct and recombine them internally using a macro. There should be no breaking | ||
| changes from this. This means there are also namespaces (as well as the old `Features::*`) for all wgpu specific | ||
| features and webgpu feature (`FeaturesWGPU` and `FeaturesWebGPU` respectively) and `Features::from_internal_flags` which | ||
| allow you to be explicit about whether features you need are available on the web too. | ||
|
|
||
| By @Vecvec in [#6905](https://github.com/gfx-rs/wgpu/pull/6905), [#7086](https://github.com/gfx-rs/wgpu/pull/7086) | ||
|
|
Member
Author
There was a problem hiding this comment.
Heads up to @gfx-rs/wgpu that this is getting promoted to a major CHANGELOG item.
9 tasks
This isn't user-facing, so there doesn't seem to be a real reason to keep this here.
This entry is backwards-compatible, so it can be "promoted" from `Changes` to "just" a highlight. 🙂
77ce83e to
6fc4c77
Compare
cwfitzgerald
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for more details. Fine to squash or rebase.