WGSL: Add a skeleton for diagnostic filter rules/diagnostic(…); that reports nice errors#6456
Merged
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom Oct 30, 2024
Conversation
diagnostic(…); that reports nice errors
7 tasks
ErichDonGubler
commented
Oct 23, 2024
2859ecf to
d139d1c
Compare
ErichDonGubler
commented
Oct 23, 2024
d139d1c to
555c643
Compare
ErichDonGubler
commented
Oct 24, 2024
04794a4 to
3764f91
Compare
teoxoy
previously requested changes
Oct 25, 2024
7 tasks
3764f91 to
d6b419a
Compare
7 tasks
4d609af to
2ea2cd0
Compare
2ea2cd0 to
97d3556
Compare
97d3556 to
290600b
Compare
teoxoy
approved these changes
Oct 30, 2024
ErichDonGubler
commented
Oct 30, 2024
290600b to
d7a3b6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
diagnostic(…)) #5320.diagnostic(…);directives andderivative_uniformitytriggering rule #6148.Description
Recommended review experience is commit-by-commit. Each individual commit should pass CI!
Finishes building out a parsing skeleton for all directives (see also #6352, #6424, #6350). Paves the way for us to actually track diagnostic filters, and apply them.
Testing
Testing has been done manually to @ErichDonGubler's satisfaction. Test coverage for this parsing will be added in #6457.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.