test(naga): add coverage for diagnostic directive parsing#6457
Closed
ErichDonGubler wants to merge 10 commits intogfx-rs:trunkfrom
Closed
test(naga): add coverage for diagnostic directive parsing#6457ErichDonGubler wants to merge 10 commits intogfx-rs:trunkfrom
diagnostic directive parsing#6457ErichDonGubler wants to merge 10 commits intogfx-rs:trunkfrom
Conversation
diagnostic directive parsingdiagnostic directive parsing
Merged
7 tasks
562bd78 to
c97fc71
Compare
23406ca to
3389296
Compare
11 tasks
3389296 to
0c5f071
Compare
This resolves ambiguity that will be introduced in the subsequent commit that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
0c5f071 to
3c78456
Compare
3c78456 to
ed4127d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests
diagnosticparsing added in #6456.Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.