WGSL: Add a skeleton for enable-extensions/enable …; that reports nice errors#6424
Merged
ErichDonGubler merged 3 commits intogfx-rs:trunkfrom Oct 22, 2024
Conversation
2e61c71 to
cb8630b
Compare
ErichDonGubler
commented
Oct 18, 2024
13 tasks
ErichDonGubler
commented
Oct 18, 2024
cb8630b to
94a317f
Compare
ErichDonGubler
commented
Oct 18, 2024
94a317f to
1995464
Compare
teoxoy
requested changes
Oct 21, 2024
enable …;) that reports nice errors
enable …;) that reports nice errorsenable …; that reports nice errors
Member
Author
Member
|
That's fine with me. |
5702588 to
765dacf
Compare
Co-Authored-By: FL33TW00D <chris@fleetwood.dev>
765dacf to
bcee0c7
Compare
7 tasks
enable …; that reports nice errorsenable …; that reports nice errors
This was referenced Oct 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
enable clip_distancesextension #6236, and Converge dual-source blending with the WebGPU standard #6402.Description
This PR is much like #6352, but for the
enabledirective; it unblocks work onenableextensions in WGSL by serving as a foundation on which to build individual extension functionality. It does the following:enableextension list after we encounter anenablein the directive parse path keyword, instead of emitting an unimplemented directive error.enummodeling all known extensions, including standard-but-unimplemented ones.Note that this PR does not actually implement any extensions yet—see also the
UnimplementedEnableExtension::tracking_issue_nummethod added in this PR for references to follow-up work for those.Testing
enabledirective parsing #6444.Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.