Use VK_EXT_robustness2 only when not using an outdated intel iGPU driver#4602
Use VK_EXT_robustness2 only when not using an outdated intel iGPU driver#4602teoxoy merged 11 commits intogfx-rs:trunkfrom TheoDulka:intel-igpu-VK_EXT_robustness2
VK_EXT_robustness2 only when not using an outdated intel iGPU driver#4602Conversation
cwfitzgerald
left a comment
There was a problem hiding this comment.
Unfortunately I don't think this will work directly. You can't just remove the extension from the list.
We should instead just set the feature flag to false - in adapter.rs:236, we can just flip it false on this condition.
…sue for context in comment
Yeah I realize that now, but I don't understand how I would do this:
|
… than removing the extension. Also added another check for intel driver and not mesa
VK_EXT_robustness2 to extensions only when not using an outdated intel iGPU driverVK_EXT_robustness2 only when not using an outdated intel iGPU driver
cwfitzgerald
left a comment
There was a problem hiding this comment.
Test code looks good, just some changes on the enabling code.
Please re-request a review from me once the changes are addressed to make sure I see it!
Removing the ExtRobustness2 from the supported_extensions
cwfitzgerald
left a comment
There was a problem hiding this comment.
Nothing wrong with the code, just want teo to have a final look before we merge
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #4599, fixes bevyengine/bevy#8037 and fixes bevyengine/bevy#8395
Description
Intel iGPUs with outdated drivers can break rendering if
VK_EXT_robustness2is pushed.The solution is to not push if its driver version is before 31.0.101.2115, because this one works. There's probably an earlier functional version as it was just the earliest version I could find and try (due to Intel's End Of Life on 6th gen proc).
Testing
Not really something testable beyond getting an Intel iGPU laptop and seeing if it is unable to render. I used the shadow example for my testing.