Fix build for iOS#385
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Nov 27, 2019
jinleili:master
Merged
Conversation
Contributor
jinleili
commented
Nov 27, 2019
bors bot
added a commit
that referenced
this pull request
Nov 27, 2019
385: Fix build for iOS r=kvark a=grenlight ``` Compiling wgpu-native v0.4.0 (https://github.com/gfx-rs/wgpu?rev=b51053dc2dc3bbe9b2ba050fde42eeb6405fe092#b51053dc) error[E0422]: cannot find struct, variant or union type `Surface` in this scope --> /Users/LiJinlei/.cargo/git/checkouts/wgpu-53e70f8674b08dd4/b51053d/wgpu-native/src/device.rs:24:24 | 24 | Rwh::IOS(h) => Surface { | ^^^^^^^ not found in this scope help: possible candidate is found in another module, you can import it into scope ``` Co-authored-by: LiJinlei <grenlight@icloud.com>
Member
|
Weird though, I thought we had iOS on CI: Line 35 in b51053d |
Contributor
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
385: Move `backends: BackendBit` parameter to `Instance::new()` r=kvark a=Kimundi Fixes gfx-rs#337 Blocked on gfx-rs#730. Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.