Skip to content

Fix life cycle of swap chain framebuffers#337

Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom
kvark:sc-framebuffer
Sep 11, 2019
Merged

Fix life cycle of swap chain framebuffers#337
bors[bot] merged 1 commit intogfx-rs:masterfrom
kvark:sc-framebuffer

Conversation

@kvark
Copy link
Copy Markdown
Member

@kvark kvark commented Sep 10, 2019

Fixes #78

The new swapchain model requires framebuffers to be destroyed right after presentation.

@kvark
Copy link
Copy Markdown
Member Author

kvark commented Sep 11, 2019

Fixes a part of gfx-rs/wgpu-rs#72

Copy link
Copy Markdown
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 11, 2019
337: Fix life cycle of swap chain framebuffers r=grovesNL a=kvark

Fixes #78 

The new swapchain model requires framebuffers to be destroyed right after presentation.

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Sep 11, 2019

Build succeeded

@bors bors bot merged commit 050b716 into gfx-rs:master Sep 11, 2019
@kvark kvark deleted the sc-framebuffer branch September 12, 2019 01:41
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
385: Move `backends: BackendBit` parameter to `Instance::new()` r=kvark a=Kimundi

Fixes gfx-rs#337
Blocked on gfx-rs#730.


Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS] minimized and hidden (cmd+h) leaks memory and blocks.

2 participants