More validation of the surface texture lifetime#1892
Merged
kvark merged 1 commit intogfx-rs:masterfrom Sep 1, 2021
Merged
Conversation
cwfitzgerald
approved these changes
Sep 1, 2021
09fecef to
2f63a3a
Compare
Member
Author
|
Removing the label - technically a breaking change. |
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
6 tasks
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
nical
pushed a commit
that referenced
this pull request
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #1878
Description
Adds
has_workflag to surface textures. This is temporary, until #1688 takes a better care of it. cc @WumpfAdds a few error conditions in addition to the "no work done":
Testing
Manually tested