Remove TextureInner::Surface::has_work.#5200
Merged
nical merged 3 commits intogfx-rs:trunkfrom Feb 9, 2024
Merged
Conversation
bac8999 to
9bd29f7
Compare
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted. Fixes gfx-rs#3189. This flag was added in gfx-rs#1892 with a note that it was going to be temporary until gfx-rs#1688 landed.
9bd29f7 to
d348866
Compare
nical
approved these changes
Feb 9, 2024
Contributor
Author
|
Thank you for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no work is submitted for a frame, presenting the surface results in a timeout due to no work having been submitted.
Fixes #3189.
This flag was added in #1892 with a note that it was going to be temporary until #1688 landed.
Testing
Tested by commenting out the rendering code of the cube example and running it with and without this patch.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.