Skip to content

[gl] Color mask warning fix#3608

Merged
bors[bot] merged 2 commits intogfx-rs:masterfrom
kvark:gl-fixes
Jan 20, 2021
Merged

[gl] Color mask warning fix#3608
bors[bot] merged 2 commits intogfx-rs:masterfrom
kvark:gl-fixes

Conversation

@kvark
Copy link
Copy Markdown
Member

@kvark kvark commented Jan 20, 2021

Fixes

[2021-01-19T16:50:33Z WARN gfx_backend_gl::queue] GLES and WebGL do not support per-target color masks. Falling back on global mask.

@kvark
Copy link
Copy Markdown
Member Author

kvark commented Jan 20, 2021

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jan 20, 2021

@bors bors bot merged commit 1e57154 into gfx-rs:master Jan 20, 2021
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Jan 23, 2021
1163: Bump gfx to latest master r=kvark a=mkeeter

**Connections**
- This bumps `gfx` to [#3610](gfx-rs/gfx#3610), and also includes [#3608](gfx-rs/gfx#3608) and [#3609](gfx-rs/gfx#3608)
- [Here](gfx-rs/wgpu-native#66) is a draft PR to `wgpu-native`
- `wgpu-rs` requires a one-line fix to the `texture_view_drop` call (which now takes a boolean); I can PR this next.

**Description**
This fixes [pathological shader complexity in SPIRV-Cross](KhronosGroup/SPIRV-Cross#1594), as well as a few other `gfx` PRs.

**Testing**
I updated `wgpu-native` to use this branch, then updated my [toy raytracer](https://github.com/mkeeter/rayray) to use the resulting `dylibs` and confirmed that it no longer takes forever to compile the pathological shader.

In addition, I updated `wgpu-rs` and went through the examples; nothing seems out of place.

Co-authored-by: Matt Keeter <matt.j.keeter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant