Merged
Conversation
teoxoy
requested changes
Mar 21, 2023
Member
teoxoy
left a comment
There was a problem hiding this comment.
There are a few other things that don't look right with lod_clamp but could be addressed by a different PR.
lod_max_clampneeds to default to32(right now it defaults tof32::MAX)lod_clampis set toNoneiflod_max_clamp > 32which doesn't seem rightdx12andvulkanthen map alod_clamp: Noneto0.0..16.0which also doesn't seem right; I think we should makelod_clamprequired at the hal level
Member
Author
|
K, went a little hog wild fixing up sampler stuff. I also brought aniso behavior inline with the spec and made the errors better. |
13babec to
748f7fa
Compare
748f7fa to
3c4ee19
Compare
Member
|
Ah, actually one remaining thing regarding the LOD changes, could you also update the Default impl of the sampler descriptors? I'm not sure why we have 2 types of |
d323eb9 to
efd0c8b
Compare
teoxoy
reviewed
Mar 21, 2023
3d98183 to
b2aab81
Compare
b2aab81 to
e948314
Compare
teoxoy
requested changes
Mar 21, 2023
0222918 to
00e795d
Compare
teoxoy
approved these changes
Mar 21, 2023
cwfitzgerald
commented
Mar 21, 2023
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 22, 2023
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 22, 2023
cwfitzgerald
added a commit
that referenced
this pull request
Mar 22, 2023
tychedelia
added a commit
to tychedelia/nannou
that referenced
this pull request
Oct 10, 2023
zmitchell
pushed a commit
to zmitchell/splatter
that referenced
this pull request
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Description
Couple issues I found when debugging a problem:
NotMipmapped(which unconditionally samples mip 0) when the LodClamp was None. This is incorrect, LodClamp of None just means there's no restrictions on the Lod.texelFetch-ing texels of different mipmaps. This would potentially blend the mipmap levels in an unintended way.Also resolves #3275.
Testing
Tested using rend3.