Skip to content

fix: Fix npx @spotlightjs/spotlight#457

Merged
BYK merged 1 commit intomainfrom
byk/fix/npx
Jul 25, 2024
Merged

fix: Fix npx @spotlightjs/spotlight#457
BYK merged 1 commit intomainfrom
byk/fix/npx

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jul 25, 2024

Due to a binary name clash between @spotlightjs/spotlight and @spotlightjs/sidecar (which is a dependency of the former), npx @spotlightjs/spotlight was running the binary from the sidecar, which does not have the standalone overlay. This PR fixes the issue by renaming the @spotlightjs/spotlight binary name to spotlight (from spotlight-sidecar).

Fixes #385.

Due to a binary name clash between @spotlightjs/spotlight and @spotlightjs/sidecar (which is a dependency of the former), `npx @spotlightjs/spotlight` was running the binary from the sidecar, which does not have the standalone overlay. This PR fixes the issue by renaming the `@spotlightjs/spotlight` binary name to `spotlight` (from `spotlight-sidecar`).

Fixes #385.
@vercel
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 10:14pm

@BYK BYK merged commit 6cf5de8 into main Jul 25, 2024
@BYK BYK deleted the byk/fix/npx branch July 25, 2024 22:16
BYK pushed a commit that referenced this pull request Jul 29, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/electron@1.1.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

### Patch Changes

-   Updated dependencies

\[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/sidecar@1.6.0
    -   @spotlightjs/overlay@2.2.0

## @spotlightjs/overlay@2.2.0

### Minor Changes

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

### Patch Changes

-   Fix incompatibility between Spotlight and Storybook's bundling.
    ([#420](#420))

## @spotlightjs/sidecar@1.6.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

## @spotlightjs/spotlight@2.2.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

### Patch Changes

-   Fix `npx @spotlightjs/spotlight` not running standalone overlay
    ([#457](#457))

-   Fix incompatibility between Spotlight and Storybook's bundling.
    ([#420](#420))

-   Updated dependencies

\[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/sidecar@1.6.0
    -   @spotlightjs/overlay@2.2.0

## @spotlightjs/astro@2.1.2

### Patch Changes

-   Updated dependencies

\[[`6cf5de875f3f8e5a6ff0ec165dbd71af3b1932f5`](6cf5de8),

[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/spotlight@2.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dcramer pushed a commit that referenced this pull request Jun 3, 2025
Due to a binary name clash between @spotlightjs/spotlight and
@spotlightjs/sidecar (which is a dependency of the former), `npx
@spotlightjs/spotlight` was running the binary from the sidecar, which
does not have the standalone overlay. This PR fixes the issue by
renaming the `@spotlightjs/spotlight` binary name to `spotlight` (from
`spotlight-sidecar`).

Fixes #385.
dcramer pushed a commit that referenced this pull request Jun 3, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/electron@1.1.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

### Patch Changes

-   Updated dependencies

\[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/sidecar@1.6.0
    -   @spotlightjs/overlay@2.2.0

## @spotlightjs/overlay@2.2.0

### Minor Changes

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

### Patch Changes

-   Fix incompatibility between Spotlight and Storybook's bundling.
    ([#420](#420))

## @spotlightjs/sidecar@1.6.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

## @spotlightjs/spotlight@2.2.0

### Minor Changes

- Add ability to use sidecar URL in a DSN
([#452](#452))

- Move contextlines provider to sidecar
([#454](#454))

- Add 'open in editor' icon
([#462](#462))

### Patch Changes

-   Fix `npx @spotlightjs/spotlight` not running standalone overlay
    ([#457](#457))

-   Fix incompatibility between Spotlight and Storybook's bundling.
    ([#420](#420))

-   Updated dependencies

\[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/sidecar@1.6.0
    -   @spotlightjs/overlay@2.2.0

## @spotlightjs/astro@2.1.2

### Patch Changes

-   Updated dependencies

\[[`6cf5de875f3f8e5a6ff0ec165dbd71af3b1932f5`](6cf5de8),

[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b),

[`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f),

[`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070),

[`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]:
    -   @spotlightjs/spotlight@2.2.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 whilst accessing the NPX Built in Overlay

1 participant