Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2b8c9e7 to
f0cf671
Compare
dcramer
approved these changes
Jul 25, 2024
Member
dcramer
left a comment
There was a problem hiding this comment.
Didn't review in detail but general change makes sense - not sure if we'll be able to keep this kind of behavior if Sidecar runs remotely though (which is fine)
Member
Author
|
Aware of the dependency on being local. Will look into that later. |
BYK
pushed a commit
that referenced
this pull request
Jul 29, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/electron@1.1.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) ### Patch Changes - Updated dependencies \[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/sidecar@1.6.0 - @spotlightjs/overlay@2.2.0 ## @spotlightjs/overlay@2.2.0 ### Minor Changes - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ### Patch Changes - Fix incompatibility between Spotlight and Storybook's bundling. ([#420](#420)) ## @spotlightjs/sidecar@1.6.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ## @spotlightjs/spotlight@2.2.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ### Patch Changes - Fix `npx @spotlightjs/spotlight` not running standalone overlay ([#457](#457)) - Fix incompatibility between Spotlight and Storybook's bundling. ([#420](#420)) - Updated dependencies \[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/sidecar@1.6.0 - @spotlightjs/overlay@2.2.0 ## @spotlightjs/astro@2.1.2 ### Patch Changes - Updated dependencies \[[`6cf5de875f3f8e5a6ff0ec165dbd71af3b1932f5`](6cf5de8), [`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/spotlight@2.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
This change moves the contextlines provider to the sidecar from the Vite plugin opening it up to all SDKs and integrations, not just Vite-based ones. This also means we do not clobber Vite dev server's URL-space (not that it was a problem, but alas). This required adding a setter to `SentryDataCache` class as it was used as a singleton from its module and handles the additional context line fetching per earlier PRs. It would be good to refactor this usage to make it more contained/encapsulated. Closes #449.
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/electron@1.1.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) ### Patch Changes - Updated dependencies \[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/sidecar@1.6.0 - @spotlightjs/overlay@2.2.0 ## @spotlightjs/overlay@2.2.0 ### Minor Changes - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ### Patch Changes - Fix incompatibility between Spotlight and Storybook's bundling. ([#420](#420)) ## @spotlightjs/sidecar@1.6.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ## @spotlightjs/spotlight@2.2.0 ### Minor Changes - Add ability to use sidecar URL in a DSN ([#452](#452)) - Move contextlines provider to sidecar ([#454](#454)) - Add 'open in editor' icon ([#462](#462)) ### Patch Changes - Fix `npx @spotlightjs/spotlight` not running standalone overlay ([#457](#457)) - Fix incompatibility between Spotlight and Storybook's bundling. ([#420](#420)) - Updated dependencies \[[`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/sidecar@1.6.0 - @spotlightjs/overlay@2.2.0 ## @spotlightjs/astro@2.1.2 ### Patch Changes - Updated dependencies \[[`6cf5de875f3f8e5a6ff0ec165dbd71af3b1932f5`](6cf5de8), [`0a6486b14d96a0eafec27a94707e4715b9fc3583`](0a6486b), [`9a7357f1dedc66d030358176bee777715b09c41b`](9a7357f), [`06f3070867534641dbb5c394e5513ca9781bbfa8`](06f3070), [`725cbb5daea8682fdf8fefb952ddce68c97c4d6f`](725cbb5)]: - @spotlightjs/spotlight@2.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the contextlines provider to the sidecar from the Vite plugin opening it up to all SDKs and integrations, not just Vite-based ones. This also means we do not clobber Vite dev server's URL-space (not that it was a problem, but alas).
This required adding a setter to
SentryDataCacheclass as it was used as a singleton from its module and handles the additional context line fetching per earlier PRs. It would be good to refactor this usage to make it more contained/encapsulated.Closes #449.