Fix setting the sentry-trace header in net/http#1922
Merged
sl0thentr0py merged 1 commit intomasterfrom Oct 27, 2022
Merged
Conversation
06b89b4 to
55a4b69
Compare
Contributor
|
@sl0thentr0py Good catch 👍 Can we add a regression test for that case? |
9dc905c to
8e04a02
Compare
Member
Author
|
@st0012 gentle ping for re-review |
st0012
approved these changes
Oct 25, 2022
8e04a02 to
3c39de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I made a mistake in #1920 that wasn't caught by the tests that just check the request object after everything happens.
The header should be set before the request actually runs in
super.