Use Sentry.with_child_span in redis and net/http patches#1920
Merged
sl0thentr0py merged 1 commit intomasterfrom Oct 20, 2022
Merged
Use Sentry.with_child_span in redis and net/http patches#1920sl0thentr0py merged 1 commit intomasterfrom
Sentry.with_child_span in redis and net/http patches#1920sl0thentr0py merged 1 commit intomasterfrom
Conversation
Sentry.with_child_span in redis and net/http patches
AbhiPrasad
approved these changes
Oct 20, 2022
st0012
approved these changes
Oct 20, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
This may be nitpicking, but if there's a behaviour change, is it still just a refactoring?
Should the user notice anything from the changes? e.g. different span nesting
Member
Author
|
@st0012 yea fair point, the nesting might change (be more accurate). |
4b71290 to
2a261f0
Compare
2a261f0 to
c27f518
Compare
st0012
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from using
span.start_childexplicitly and use the top levelSentry.with_child_span.This is necessary going forward for having some top-level api control for disabling sentry instrumentation if we're using open telemetry.
Note: I had to remove one net/http test for the unsampled case since that behaviour changed now. But this is fine as in principle the
sampledflag just controls the finalhub.capture_eventand not the actual span recording.