Skip to content

Fix report_after_job_retries's decision logic#1704

Merged
st0012 merged 2 commits intomasterfrom
fix-#1698
Jan 29, 2022
Merged

Fix report_after_job_retries's decision logic#1704
st0012 merged 2 commits intomasterfrom
fix-#1698

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jan 27, 2022

Fixes #1698

@st0012 st0012 added this to the 5.0.2 milestone Jan 27, 2022
@st0012 st0012 self-assigned this Jan 27, 2022
@st0012 st0012 requested a review from sl0thentr0py January 27, 2022 17:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #1704 (0f1b1aa) into master (a7f7450) will decrease coverage by 0.00%.
The diff coverage is 98.33%.

❗ Current head 0f1b1aa differs from pull request most recent head 0c575fc. Consider uploading reports for the commit 0c575fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
- Coverage   98.56%   98.56%   -0.01%     
==========================================
  Files         136      136              
  Lines        7737     7782      +45     
==========================================
+ Hits         7626     7670      +44     
- Misses        111      112       +1     
Impacted Files Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/error_handler.rb 95.83% <91.66%> (-4.17%) ⬇️
sentry-sidekiq/spec/sentry/sidekiq_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f7450...0c575fc. Read the comment docs.

@st0012 st0012 merged commit d6b63bb into master Jan 29, 2022
@st0012 st0012 deleted the fix-#1698 branch January 29, 2022 09:34
lewispb added a commit to lewispb/sentry-ruby that referenced this pull request Feb 1, 2022
* master:
  feat(performance): Sync activerecord and net-http span names (getsentry#1681)
  Register Sentry's ErrorSubscriber for Rails 7.0+ apps (getsentry#1705)
  Support serializing ActiveRecord job arguments in global id form (getsentry#1688)
  release: 5.0.2
  Fix report_after_job_retries's decision logic (getsentry#1704)
  Followup of getsentry#1701 (getsentry#1703)
  Capture transaction tags (getsentry#1701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

report_after_job_retries option is ignored if sidekiq workers's retry is not specified

3 participants